Skip to content

Adjust dbg.value/dbg.declare checks for LLVM update #124830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2024
Merged

Adjust dbg.value/dbg.declare checks for LLVM update #124830

merged 1 commit into from
May 7, 2024

Conversation

aeubanks
Copy link
Contributor

@aeubanks aeubanks commented May 6, 2024

llvm/llvm-project#89799 changes llvm.dbg.value/declare intrinsics to be in a different, out-of-instruction-line representation. For example
call void @llvm.dbg.declare(...)
becomes
#dbg_declare(...)

Update tests accordingly to work with both the old and new way.

@aeubanks
Adjust dbg.value/dbg.declare checks for LLVM update
6c348ac 
llvm/llvm-project#89799 changes llvm.dbg.value/declare intrinsics to be in a different, out-of-instruction-line representation. For example
  call void @llvm.dbg.declare(...)
becomes
  #dbg_declare(...)

Update tests accordingly to work with both the old and new way.
@rustbot
Copy link
Collaborator

rustbot commented May 6, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 6, 2024
@aeubanks
Copy link
Contributor Author

aeubanks commented May 6, 2024

@rustbot label: + llvm-main
r? @durin42

@rustbot rustbot assigned durin42 and unassigned Mark-Simulacrum May 6, 2024
@rustbot
Copy link
Collaborator

rustbot commented May 6, 2024

Error: Parsing relabel command in comment failed: ...' label: +' | error: empty label at >| ' llvm-main'...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@aeubanks
Copy link
Contributor Author

aeubanks commented May 6, 2024

@rustbot label: +llvm-main
r? @durin42

@rustbot
Copy link
Collaborator

rustbot commented May 6, 2024

Could not assign reviewer from: durin42.
User(s) durin42 are either the PR author, already assigned, or on vacation, and there are no other candidates.
Use r? to specify someone else to assign.

@rustbot rustbot added the llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) label May 6, 2024
@durin42
Copy link
Contributor

durin42 commented May 6, 2024

That is...exactly the cursed FileCheck hackery I didn't want to spend the brainpower on. Many many thanks.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 7, 2024

📌 Commit 6c348ac has been approved by durin42

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2024
@bors
Copy link
Collaborator

bors commented May 7, 2024

⌛ Testing commit 6c348ac with merge 5ae5d13...

@bors
Copy link
Collaborator

bors commented May 7, 2024

☀️ Test successful - checks-actions
Approved by: durin42
Pushing 5ae5d13 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 7, 2024
@bors bors merged commit 5ae5d13 into rust-lang:master May 7, 2024
@rustbot rustbot added this to the 1.80.0 milestone May 7, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5ae5d13): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.4% [1.4%, 1.4%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.3% [1.3%, 1.3%] 1
Regressions ❌
(secondary)		 4.2% [4.2%, 4.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.3% [1.3%, 1.3%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.5% [2.9%, 4.0%] 5
Improvements ✅
(primary)		 -2.2% [-3.1%, -1.3%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.2% [-3.1%, -1.3%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 675.496s -> 673.849s (-0.24%)
Artifact size: 315.97 MiB -> 315.95 MiB (-0.01%)

@workingjubilee workingjubilee mentioned this pull request May 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@durin42 durin42

Labels
llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.
6 participants
@aeubanks @rustbot @durin42 @bors @rust-timer @Mark-Simulacrum